Repository navigation
fix(shared): verify the sign-up email and phone before collecting missing fields - #10883
austincalvelage wants to merge 7 commits into
Conversation
getSignInNextStep and getSignUpNextStep now return SignInNextStep and SignUpNextStep, so a sign-up caller can switch over its steps exhaustively without handling sign-in steps it never receives. NextStep stays as their union.
…sing fields getSignUpNextStep followed navigateToNextStepSignUp's order, which only the OAuth return and sign-up-if-missing paths use. It now follows completeSignUpFlow, the order the sign-up forms use.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: eeeeaca The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-biometrics
@clerk/expo-google-signin
@clerk/expo-native-components
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
API Changes Report
Summary
@clerk/sharedCurrent version: 4.46.0 Subpath
|


Description
getSignUpNextStepnow returns the email and phone verification steps before thefieldsstep. This is the ordercompleteSignUpFlowfollows in the current sign-up form: verify the email, then the phone, then collect the missing fields.The order of sign-up steps is a client decision. FAPI completes a sign-up once every requirement is met, whatever order they are met in, so one function in
sharedcan keep every JS client on the same order.Also in this PR:
NextStepis split intoSignInNextStepandSignUpNextStep, so a sign-up caller cannot receive a sign-in step.NextStepstays as the union of the two.unknown: FAPI computes the missing requirement but does not send it.Nothing on
maincalls these helpers outside their tests, so no shipped behavior changes. The Mosaic sign-up in #10881 is the first caller.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change